Skip to content

[Extensions.Enrichment] Add exception handling to trace enrichment#4165

Merged
martincostello merged 5 commits intoopen-telemetry:mainfrom
ysolomchenko:Trace-enrichment-callbacks-lack-exception-handling
Apr 21, 2026
Merged

[Extensions.Enrichment] Add exception handling to trace enrichment#4165
martincostello merged 5 commits intoopen-telemetry:mainfrom
ysolomchenko:Trace-enrichment-callbacks-lack-exception-handling

Conversation

@ysolomchenko
Copy link
Copy Markdown
Contributor

Fixes # N/A
Design discussion issue # N/A

Found by Codex analysis

Changes

Fixed trace enrichment callbacks so exceptions thrown by user-provided enrichers or enrichment actions no longer interrupt trace processing.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added the comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment label Apr 21, 2026
@ysolomchenko ysolomchenko marked this pull request as ready for review April 21, 2026 07:54
@ysolomchenko ysolomchenko requested a review from a team as a code owner April 21, 2026 07:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.92%. Comparing base (b4c4b44) to head (06c17e1).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4165      +/-   ##
==========================================
+ Coverage   73.74%   73.92%   +0.17%     
==========================================
  Files         466      459       -7     
  Lines       18314    18304      -10     
==========================================
+ Hits        13506    13531      +25     
+ Misses       4808     4773      -35     
Flag Coverage Δ
unittests-Extensions 90.78% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <100.00%> (ø)
unittests-Instrumentation.Cassandra ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sions.Enrichment/Internal/EnrichmentEventSource.cs 100.00% <100.00%> (ø)
...ions.Enrichment/Internal/TraceEnrichmentActions.cs 100.00% <100.00%> (ø)
...ns.Enrichment/Internal/TraceEnrichmentProcessor.cs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/OpenTelemetry.Extensions.Enrichment/Internal/TraceEnrichmentActions.cs Outdated
Comment thread src/OpenTelemetry.Extensions.Enrichment/Internal/EnrichmentEventSource.cs Outdated
ysolomchenko and others added 2 commits April 21, 2026 11:57
@martincostello martincostello added this pull request to the merge queue Apr 21, 2026
Merged via the queue into open-telemetry:main with commit 66c065c Apr 21, 2026
79 checks passed
This was referenced Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants